Skip to content

Conversation

@janbaum
Copy link
Contributor

@janbaum janbaum commented Oct 13, 2025

Backport for #7750

@mejo- mejo- changed the base branch from main to stable31 October 13, 2025 16:19
@mejo-
Copy link
Member

mejo- commented Oct 13, 2025

@janbaum this is a good start 😊

I changed the base branch for this PR to stable31, this was missing - it was still set to main. We don't want to merge this PR into main though. That's also why it had listed so many commits.

Regarding the code changes, it's a bit mean with the linter: on stable31 we still use older versions of eslint and code style, that's why the coding conventions are different. When you check out stable31 locally, you have to run npm ci once again before running npm run lint.

A backport to a stable release should contain just the changes that you want to backport, no further changes to the file. So ideally you revert all changes to the file except the replacement of :checked=... with :model-value=....

@mejo- mejo- changed the title Backport/7750/stable31 [stable31] fix(PreviewOptions): set active radio button on open Oct 13, 2025
@mejo-
Copy link
Member

mejo- commented Oct 14, 2025

As discussed with @janbaum I took over and opened #7784 as I lack permissions to push into his repo/branch.

@mejo- mejo- closed this Oct 14, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants