Skip to content

[stable32] Fix: prevent the collision between y-websocket reconnectTimeout and polling interval #7823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Oct 23, 2025
Merged

[stable32] Fix: prevent the collision between y-websocket reconnectTimeout and polling interval #7823

juliusknorr merged 1 commit into from
Oct 23, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Oct 23, 2025

Backport of PR #7822

@backportbot backportbot bot requested a review from max-nextcloud as a code owner October 23, 2025 17:33
@backportbot backportbot bot requested a review from juliusknorr October 23, 2025 17:33
@backportbot backportbot bot requested a review from mejo- as a code owner October 23, 2025 17:33
@backportbot backportbot bot requested a review from benjaminfrueh October 23, 2025 17:33
@backportbot backportbot bot added this to the Nextcloud 32.0.1 milestone Oct 23, 2025
@benjaminfrueh @backportbot
Fix: prevent the collision between y-websocket and polling interval b…
87a5600 
…y handling the timing more gracefully

Signed-off-by: Benjamin Frueh <[email protected]>
@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.08%. Comparing base (72d0869) to head (87a5600).
⚠️ Report is 2 commits behind head on stable32.

Additional details and impacted files 
@@             Coverage Diff              @@
##           stable32    #7823      +/-   ##
============================================
+ Coverage     53.27%   60.08%   +6.81%     
============================================
  Files           503      502       -1     
  Lines         43650    38699    -4951     
  Branches       1135     1134       -1     
============================================
  Hits          23254    23254              
+ Misses        20288    15338    -4950     
+ Partials        108      107       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo-
Copy link
Member

mejo- commented Oct 23, 2025

/backport! to stable31

@backportbot backportbot bot mentioned this pull request Oct 23, 2025
Merged
@juliusknorr juliusknorr merged commit 371b0d2 into stable32 Oct 23, 2025
64 of 65 checks passed
@juliusknorr juliusknorr deleted the backport/7822/stable32 branch October 23, 2025 17:49
@nextcloud-bot nextcloud-bot mentioned this pull request Oct 23, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@mejo- mejo- mejo- approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@benjaminfrueh benjaminfrueh Awaiting requested review from benjaminfrueh

Assignees

@benjaminfrueh benjaminfrueh

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 32.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@mejo- @AndyScherzinger @juliusknorr @benjaminfrueh