Skip to content

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Oct 28, 2025

Also introduces Playwright and adds tests for offline UI changes.

Fixes: nextcloud/collectives#1868

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo- mejo- requested a review from benjaminfrueh October 28, 2025 11:16
@mejo- mejo- self-assigned this Oct 28, 2025
@mejo- mejo- requested a review from max-nextcloud as a code owner October 28, 2025 11:16
@mejo- mejo- force-pushed the fix/offline_disable_link_to_file branch from dbee850 to 997d6b0 Compare October 28, 2025 11:19
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.06%. Comparing base (3e1b521) to head (8359f88).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Menu/ActionInsertLink.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7870      +/-   ##
==========================================
- Coverage   47.10%   47.06%   -0.04%     
==========================================
  Files         141      141              
  Lines        3883     3886       +3     
  Branches      733      733              
==========================================
  Hits         1829     1829              
- Misses       1760     1763       +3     
  Partials      294      294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo- mejo- force-pushed the fix/offline_disable_link_to_file branch from b8c9e89 to d3b3b2f Compare October 28, 2025 16:39
I was sick of debugging flaky Cypress tests, so I gave Playwright a try.

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- force-pushed the fix/offline_disable_link_to_file branch from d3b3b2f to 8359f88 Compare October 29, 2025 09:14
@mejo- mejo- merged commit 185ae8f into main Oct 29, 2025
66 of 68 checks passed
@mejo- mejo- deleted the fix/offline_disable_link_to_file branch October 29, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable upload and link to file buttons while offline

3 participants