-
Notifications
You must be signed in to change notification settings - Fork 109
fix(files): Disable suggestions bar output for not rich workspace #7875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Disable suggestions bar output for not rich workspace #7875
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier is unhappy, apart from that code looks good.
|
@marcoambrosini I know we removed the placeholder text, but now nothing is indicating to the user that they can click in there and type something if it is empty and not in focus. |
|
@juliusknorr what about re-introducing the placeholder? Why was it taken out? If accessibility is the concern, I think we could solve it by having an action that focuses the |
It was removed in #6855 when the smart picker button was added to the side. I also think we should bring it back, not only in empty rich workspace documents, but in general. |
|
|
@max-nextcloud to address those points:
|
|
Sounds good to me. I wonder if it might be easier to use the approach of the suggestion bar of checking for an empty editor for the placeholder as well. |
|
https://tiptap.dev/docs/editor/extensions/functionality/placeholder Does behave as I would expect to only render if the document is fully empty by using css rules as in the example |
|
I checked Notion and Coda, they both show the placeholder on each new paragraph. I wonder why we would want it only on empty files, but don't have strong feelings about it. @JuliaKirschenheuter, do you plan to bring back the placeholder as part of this PR? Or would you prefer if someone else takes over? I could do so if you like. |
I think it's fine to show the placeholder text on each new line (not the suggestion bar though) |
See discussion in #7875 Signed-off-by: Jonas <[email protected]>
Signed-off-by: julia.kirschenheuter <[email protected]> Signed-off-by: Jonas <[email protected]>
a01a711 to
069c5ee
Compare
|
/backport to stable32 |
|
Let's bring this in. I opened #8075 for bringing back the placeholder. |
See discussion in #7875 Signed-off-by: Jonas <[email protected]>
See discussion in #7875 Signed-off-by: Jonas <[email protected]>
📝 Summary
🖼️ Screenshots