Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
image image

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier is unhappy, apart from that code looks good.

@juliusknorr
Copy link
Member

@marcoambrosini I know we removed the placeholder text, but now nothing is indicating to the user that they can click in there and type something if it is empty and not in focus.

@marcoambrosini
Copy link
Member

marcoambrosini commented Oct 31, 2025

@juliusknorr what about re-introducing the placeholder? Why was it taken out? If accessibility is the concern, I think we could solve it by having an action that focuses the textarea within the new menu. It could read: "Add folder description"

@mejo-
Copy link
Member

mejo- commented Nov 1, 2025

@juliusknorr what about re-introducing the placeholder? Why was it taken out? If accessibility is the concern, I think we could solve it by having an action that focuses the textarea within the new menu. It could read: "Add folder description"

It was removed in #6855 when the smart picker button was added to the side. I also think we should bring it back, not only in empty rich workspace documents, but in general.

@max-nextcloud
Copy link
Collaborator

Why was it taken out?

  • It seemed redundant to write... "Type / to add" when there's a plus button right next to it.
  • Not everyone can mention people (I think it's not possible on public shares). So the "@ to mention" part would have needed to become context dependent.
  • The placeholder we used did not just show on an empty document but also in empty lines, which seemed broken to me as placeholders usually go away when something is typed into the textfield and do not show again on new emtpy lines.

@marcoambrosini
Copy link
Member

@max-nextcloud to address those points:

  1. I think It's still nice a nice invitation and it inform users about the existence of the keyboard shortcut
  2. We can skip the @ mention part
  3. This is just a bug that can be fixed

@max-nextcloud
Copy link
Collaborator

Sounds good to me. I wonder if it might be easier to use the approach of the suggestion bar of checking for an empty editor for the placeholder as well.
Previously we used the tiptap placeholder extension if i remember correctly. Fixing that seems more involved.

@juliusknorr
Copy link
Member

https://tiptap.dev/docs/editor/extensions/functionality/placeholder Does behave as I would expect to only render if the document is fully empty by using css rules as in the example

 /* Placeholder (at the top) */
  p.is-editor-empty:first-child::before {
    color: var(--gray-4);
    content: attr(data-placeholder);
    float: left;
    height: 0;
    pointer-events: none;
  }

@mejo-
Copy link
Member

mejo- commented Nov 24, 2025

I checked Notion and Coda, they both show the placeholder on each new paragraph. I wonder why we would want it only on empty files, but don't have strong feelings about it.

@JuliaKirschenheuter, do you plan to bring back the placeholder as part of this PR? Or would you prefer if someone else takes over? I could do so if you like.

@marcoambrosini
Copy link
Member

I wonder why we would want it only on empty files

I think it's fine to show the placeholder text on each new line (not the suggestion bar though)

mejo- added a commit that referenced this pull request Dec 17, 2025
See discussion in #7875

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- mentioned this pull request Dec 17, 2025
2 tasks
@mejo- mejo- force-pushed the fix/7874-Remove-suggestions-buttons-from-text-preview branch from a01a711 to 069c5ee Compare December 17, 2025 08:35
@mejo- mejo- requested a review from silverkszlo as a code owner December 17, 2025 08:35
@mejo-
Copy link
Member

mejo- commented Dec 17, 2025

/backport to stable32

@mejo- mejo- merged commit b121dec into main Dec 17, 2025
62 of 63 checks passed
@mejo- mejo- deleted the fix/7874-Remove-suggestions-buttons-from-text-preview branch December 17, 2025 08:46
@mejo-
Copy link
Member

mejo- commented Dec 17, 2025

Let's bring this in. I opened #8075 for bringing back the placeholder.

backportbot bot pushed a commit that referenced this pull request Dec 17, 2025
See discussion in #7875

Signed-off-by: Jonas <[email protected]>
mejo- added a commit that referenced this pull request Dec 17, 2025
See discussion in #7875

Signed-off-by: Jonas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove suggestions buttons from text preview

6 participants