Skip to content

fix(TextDirection): Skip composition transactions #7981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 2 commits into from
Nov 25, 2025
Merged

fix(TextDirection): Skip composition transactions #7981

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9212e7
fix(TextDirection): Skip composition transactions
mejo- Nov 25, 2025
7539fa1
test(playwright): Add regression test for CJK IME input as first char…
mejo- Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(TextDirection): Skip composition transactions 
Without this fix, inserting a CJK character via IME as first character
in a new paragraph is broken as the composition key is inserted straight
away.

Fixes: #7789

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Nov 25, 2025
commit e9212e7fa9d46f5b8c8cbef801b3dc4b8276235f
6 changes: 3 additions & 3 deletions src/extensions/TextDirection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,16 @@ function TextDirectionPlugin({ types }: { types: string[] }) {
return new Plugin({
key: new PluginKey('textDirection'),
appendTransaction: (transactions, oldState, newState) => {
const isCollabTransaction = transactions.some((tr) =>
tr.getMeta('y-sync$'),
const isCollabOrCompositionTransaction = transactions.some(
(tr) => tr.getMeta('y-sync$') || tr.getMeta('composition'),
)
const inputRulePlugin = newState.plugins.find(
(plugin) => plugin.spec.isInputRules,
)
const isInputRuleTransaction =
inputRulePlugin
&& transactions.some((tr) => tr.getMeta(inputRulePlugin))
if (isCollabTransaction || isInputRuleTransaction) {
if (isCollabOrCompositionTransaction || isInputRuleTransaction) {
return
}
const docChanges = transactions.some(
Expand Down