test: Use example.org instead of nextcloud.com for testing links #7998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI often runs into rate limits when testing against nextcloud.com and we're asked to not use nextcloud.com in tests anyway. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
test/no_nextcloud_com
branch
from
f9ff064 to
033860c
Compare
Member
Author
|
/backport to stable32 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was accidently introduced again with 51ac9ad, but we have a different approach in text. JS assets are compiled and pushed to the branches by a CI job after PRs got merged. Signed-off-by: Jonas <[email protected]>
| CYPRESS_INSTALL_BINARY: 0 | ||
| run: | | ||
| npm ci | ||
| npm run build --if-present |
Collaborator
There was a problem hiding this comment.
I think the idea here is to make sure it still builds after the npm audit update. But I guess the same would also happen in the PR created below.
Member
Author
There was a problem hiding this comment.
We had this removed in the past as well, see c253378 😉
max-nextcloud
approved these changes
Dec 1, 2025
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
example.org also had it's issues once - nextcloud/collectives@858036d
But at least there's no rate limiting.
Member
Author
|
/backport to stable31 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI often runs into rate limits when testing against nextcloud.com and we're asked to not use nextcloud.com in tests anyway.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)