Skip to content

feat: Add table-only editor API #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 6 commits into from
Dec 9, 2025
Merged

feat: Add table-only editor API #8002

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2be13d1
feat: Add table-only editor API
silverkszlo Dec 1, 2025
38b52a2
remove obsolete addOptions from PlainTable extension
silverkszlo Dec 4, 2025
931cc65
test createTable
silverkszlo Dec 4, 2025
931d82c
make editorWith non-adjustable and disable file upload in editor
silverkszlo Dec 4, 2025
477634f
refactor createTable test
silverkszlo Dec 4, 2025
45deeac
lint and refactor
silverkszlo Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lint and refactor 
Signed-off-by: silver <[email protected]>
  • Loading branch information
@silverkszlo @juliusknorr
silverkszlo authored and juliusknorr committed Dec 9, 2025
commit 45deeacc7a01ddd9ea69673d84cf6021657cbbf0
2 changes: 1 addition & 1 deletion playwright/e2e/create-table-api.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
*/

import { expect, mergeTests } from '@playwright/test'
import { test as uploadFileTest } from '../support/fixtures/upload-file'
import { test as randomUserTest } from '../support/fixtures/random-user'
import { test as uploadFileTest } from '../support/fixtures/upload-file'

const test = mergeTests(uploadFileTest, randomUserTest)

Expand Down
24 changes: 7 additions & 17 deletions src/components/Editor/PlainTableContentEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
-->

<template>
<Wrapper
:content-loaded="true"
:show-outline-outside="false">
<Wrapper :content-loaded="true" :show-outline-outside="false">
<MainContainer>
<ContentContainer :read-only="readOnly" />
</MainContainer>
Expand All @@ -22,11 +20,11 @@ import { UndoRedo } from '@tiptap/extensions'
import { provide, watch } from 'vue'
import { provideEditor } from '../../composables/useEditor.ts'
import { editorFlagsKey } from '../../composables/useEditorFlags.ts'
import { editorWidthKey } from '../../composables/useEditorWidth.ts'
import { useEditorMethods } from '../../composables/useEditorMethods.ts'
import { EDITOR_UPLOAD } from '../Editor.provider.ts'
import { editorWidthKey } from '../../composables/useEditorWidth.ts'
import { FocusTrap, PlainTable } from '../../extensions/index.js'
import { createMarkdownSerializer } from '../../extensions/Markdown.js'
import { EDITOR_UPLOAD } from '../Editor.provider.ts'
import ContentContainer from './ContentContainer.vue'

export default {
Expand All @@ -42,19 +40,11 @@ export default {
type: Boolean,
default: false,
},
showOutlineOutside: {
type: Boolean,
default: false,
},
},
emits: ['update:content'],

setup(props) {
const extensions = [
PlainTable,
UndoRedo,
FocusTrap,
]
const extensions = [PlainTable, UndoRedo, FocusTrap]
const editor = new Editor({ extensions })

const { setEditable, setContent } = useEditorMethods(editor)
Expand Down Expand Up @@ -95,9 +85,9 @@ export default {

// Emit initial content
try {
const markdown = createMarkdownSerializer(this.editor.schema).serialize(
this.editor.state.doc,
)
const markdown = createMarkdownSerializer(
this.editor.schema,
).serialize(this.editor.state.doc)
this.emit('create:content', {
json: this.editor.state.doc,
markdown,
Expand Down
12 changes: 3 additions & 9 deletions src/extensions/PlainTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,17 @@

import { Extension } from '@tiptap/core'

import PlainTableDocument from './../nodes/PlainTableDocument.js'
import EditableTable from './../nodes/EditableTable.js'
import Markdown from './Markdown.js'
import PlainTableDocument from './../nodes/PlainTableDocument.js'
import Keymap from './Keymap.js'
import Markdown from './Markdown.js'
/* eslint-disable import/no-named-as-default */
import Text from '@tiptap/extension-text'

export default Extension.create({
name: 'PlainTable',

addExtensions() {
return [
Markdown,
PlainTableDocument,
EditableTable,
Keymap,
Text,
]
return [Markdown, PlainTableDocument, EditableTable, Keymap, Text]
},
})
Loading