-
Notifications
You must be signed in to change notification settings - Fork 109
[stable29] feat: Add table-only editor API #8028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add createTable() API to enable embedding markdown tables in other apps without rich text editing features. Introduces PlainTableDocument node that restricts content to tables only, and PlainTable extension that bundles required functionality (table editing, markdown serialization). - Add PlainTableDocument node with table-only content model - Add PlainTable extension (bundles Markdown, EditableTable, etc.) - Add PlainTableContentEditor.vue component - Expose window.OCA.Text.createTable() API in editor.js - Export PlainTable from extensions/index.js Signed-off-by: silver <[email protected]>
Signed-off-by: silver <[email protected]>
Signed-off-by: silver <[email protected]>
Signed-off-by: silver <[email protected]>
Signed-off-by: silver <[email protected]>
Signed-off-by: silver <[email protected]> [skip ci]
eb07542 to
881379b
Compare
Signed-off-by: Benjamin Frueh <[email protected]>
881379b to
40be457
Compare
|
@juliusknorr I commited a fix for this backport, it works now in stable29. Note: tiptap v2 table editing is less user-friendly compared to v3, there are no quick actions, so rows and columns can only be added with the three-dot menus. |
|
Thanks also for the clarification on the limitations, this is fine for now. I guess we can forward port your changes from her then to 30 and 31 as well |
|
CI failures seem unrelated |
juliusknorr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works, thanks for wrapping this up @benjaminfrueh
|
thank you @benjaminfrueh ! |
Backport of #8002
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.