Skip to content

fix(Db): fix type errors of $id with latest server with snowflake IDs #8139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 1 commit into from
Jan 8, 2026
+0 −6
Merged

fix(Db): fix type errors of $id with latest server with snowflake IDs #8139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/Db/Document.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
* @method setChecksum(?string $checksum): void
*/
class Document extends Entity implements \JsonSerializable {
public $id = null;
// TODO: Remove obsolete field `currentVersion`
protected int $currentVersion = 0;
protected int $lastSavedVersion = 0;
Expand All @@ -38,7 +37,6 @@ class Document extends Entity implements \JsonSerializable {
protected ?string $checksum = null;

public function __construct() {
$this->addType('id', 'integer');
$this->addType('currentVersion', 'integer');
$this->addType('lastSavedVersion', 'integer');
$this->addType('lastSavedVersionTime', 'integer');
Expand Down
2 changes: 0 additions & 2 deletions lib/Db/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
* @method void setDocumentId(int $documentId)
*/
class Session extends Entity implements JsonSerializable {
public $id;
protected ?string $userId = null;
protected string $token = '';
protected string $color = '';
Expand All @@ -37,7 +36,6 @@ class Session extends Entity implements JsonSerializable {
protected int $documentId = 0;

public function __construct() {
$this->addType('id', 'integer');
$this->addType('documentId', 'integer');
$this->addType('lastContact', 'integer');
}
Expand Down
2 changes: 0 additions & 2 deletions lib/Db/Step.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,13 @@ class Step extends Entity implements JsonSerializable {
*/
public const VERSION_STORED_IN_ID = 2147483647;

public $id = null;
protected string $data = '';
protected int $version = 0;
protected int $sessionId = 0;
protected int $documentId = 0;
protected int $timestamp = 0;

public function __construct() {
$this->addType('id', 'integer');
$this->addType('version', 'integer');
$this->addType('documentId', 'integer');
$this->addType('sessionId', 'integer');
Expand Down
Loading