Skip to content

Also translate 'Add notes, ...' inside Editor #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 2 commits into from
Jun 8, 2020
Merged

Also translate 'Add notes, ...' inside Editor #852

juliusknorr merged 2 commits into from
Jun 8, 2020

Conversation

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Jun 5, 2020

Signed-off-by: Georg Ehrke [email protected]

Summary

To test this:

  • Create a new directory
  • The "Add notes, lists or links …" is translated (1)
  • Click on the text (it creates the README.md)
  • leave directory and enter it again
  • The "Add notes, lists or links …" is not translated (2)

(1) is coming from

text/src/views/RichWorkspace.vue

Line 27 in 8deeaf7

{{ t('text', 'Add notes, lists or links …') }}

(2) is coming from

text/src/EditorFactory.js

Line 84 in 8deeaf7

emptyNodeText: 'Add notes, lists or links …',

@georgehrke georgehrke requested a review from juliusknorr June 5, 2020 09:47
@georgehrke
Copy link
Member Author

georgehrke commented Jun 5, 2020

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the bugfix/627/missing_translation branch from eda6ea6 to 4b0b957 Compare June 5, 2020 09:54
@juliusknorr
Copy link
Member

juliusknorr commented Jun 8, 2020

@georgehrke Mind to rebase 🙈

@juliusknorr juliusknorr added 4. to release bug Something isn't working and removed 3. to review labels Jun 8, 2020
@georgehrke georgehrke force-pushed the bugfix/627/missing_translation branch from 4b0b957 to eda6ea6 Compare June 8, 2020 17:07
@georgehrke georgehrke force-pushed the bugfix/627/missing_translation branch from eda6ea6 to c517496 Compare June 8, 2020 17:10
@georgehrke
Copy link
Member Author

georgehrke commented Jun 8, 2020

/compile /

@npmbuildbot
Compile assets
4ffe3c4 
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@juliusknorr juliusknorr merged commit b9f3e6d into master Jun 8, 2020
@juliusknorr juliusknorr deleted the bugfix/627/missing_translation branch June 8, 2020 17:19
@juliusknorr
Copy link
Member

juliusknorr commented Jun 8, 2020

/backport c517496 to stable19

@juliusknorr
Copy link
Member

juliusknorr commented Jun 8, 2020

/backport c517496 to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 8, 2020
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

No one assigned

Labels

4. to release bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No translation - Add notes, lists or links …

3 participants

@georgehrke @juliusknorr