Only overwrite Ctrl-f when text is focussed

[juliusknorr]

• Resolves: 'Show rich workspaces' breaks CTRL+F  #802
• Target version: master

Summary

Otherwise the unified search does not trigger properly if a rich workspace is shown. With this PR the browser default search will be only triggered by text if the keydown event is triggered on the editor input.

Using the regular fallback with hitting Ctrl-F twice would not work here since when editing in the viewer the unified search is hidden in the background and therefore the user doesn't get any feedback when hitting ctrl-f for the first time. Also when having the text focused I think that searching in it is a sane default.

[azul]

Code looks good to me.

🧐 Minor nitpick: Keymap class sounds very generic and behaves generic in that all of it's behaviour is specified through the options during construction. At the same time it now implements special treatment for ctrl-f. Seems counter intuitive that by adding a keymap to the editor that handles mod-s you also get special treatment for ctrl-f.

Maybe put the plugin into a separate class like BrowserSearch or so?

[azul]

Confirmed that it fixes the issue in files.
Keeps using browser search when opening a file in the viewer and looking at the sidebar. I think that is the behavior we want.

I have not played with this in talk.

[juliusknorr]

/backport 52a20e2 to stable19

[juliusknorr]

/backport 52a20e2 to stable18