Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 23, 2025

Resolves #1597

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.62%. Comparing base (bf5cf52) to head (800090d).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1603   +/-   ##
=========================================
  Coverage     39.62%   39.62%           
  Complexity      107      107           
=========================================
  Files            20       20           
  Lines           323      323           
=========================================
  Hits            128      128           
  Misses          195      195           
Flag Coverage Δ
unittests 39.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and wörks. Very nice!

image

(But for some reason it won't work on the initial validation in the personal settings despite the password inputs having the same attributes. But I don't think that is bad as the validation will only be prompted once.)

@ChristophWurst ChristophWurst marked this pull request as ready for review May 23, 2025 09:08
@ChristophWurst
Copy link
Member Author

/compile amend /

Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@ChristophWurst ChristophWurst force-pushed the feat/otp-autocomplete branch from f1d5da3 to 800090d Compare May 23, 2025 11:53
@ChristophWurst ChristophWurst merged commit 56f085c into master May 23, 2025
27 checks passed
@ChristophWurst ChristophWurst deleted the feat/otp-autocomplete branch May 23, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support autocomplete

3 participants