Handle symlinks in updater correctly

[ggeorgg]

Also delete symlinked files, so that the updater does not stop when deleting a non-empty directory.

What do you think of this pull-request? @MorrisJobke

[MorrisJobke]

Code wise this looks good 👍 Haven't tested yet. What are the exact steps to reproduce? Link some files inside Nextcloud? How did you manage to get there?

[MorrisJobke]

Also could you update https://github.com/nextcloud/updater/blob/master/lib/Updater.php with the exact same changes? Then the CI job also get's green.

[ggeorgg]

Steps to reproduce:
Use Open SUSE Tumbleweed and install nextcloud via
sudo zypper in nextcloud
Point your browser to your nextcloud installation and select update channel daily. Reload the page and try to update your instance with the web based updater.
The update process will fail due to files which couldn't be removed beforehand by the updater itself. The files which cause this problem are symlinks that are generated at the installation because of
https://build.opensuse.org/package/view_file/openSUSE:Factory/nextcloud/nextcloud.spec?expand=1
Line 164: %fdupes -s $RPM_BUILD_ROOT/%{apache_serverroot}/%{name}
The problem is solved on my machine if we check for symlinks, files and folders in the delete functions.

[kesselb]

Basically this patch should fix an issue the open suse packager introduced by replacing duplicate files with symlinks right?

[ggeorgg]

Exactly.

[kesselb]

@ggeorgg thanks! code looks good.

[kesselb]

Build fails because your branch is a bit outdated. Could you merge latest changes from nextcloud/updater?

[ggeorgg]

I just merged the latest nextcloud updater repository into my own branch "patch-1". It may look a bit clustered now with my commits. Hope this will not be a problem. I am not quite sure if this is how it works. If it was not correct what I have done, please give me a hint on how to proceed ;)

[kesselb]

OK. Sorry there is one more thing. You need to sign off your commits (see this link for more information https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for)

You have two ways to do this:

A) I would rebase (interactive) the branch to updater/master, squash all commits into one commit, sign these commit off and force push them back.
B) Create a new branch from updater/master, apply your patch again, sign off and open a new pr.

[ggeorgg]

Unfortunatley I was not able to clean up the pull request. I opened a new one here: #180.