Skip to content

Remove obsolete pipeline php72-master #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 2 commits into from
Feb 26, 2021
Merged

Remove obsolete pipeline php72-master #333

kesselb merged 2 commits into from
Feb 26, 2021

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Feb 17, 2021

Master (which is Nextcloud 22) doesn't support PHP 7.2 any more.

For #332

@PVince81
Remove obsolete pipeline php72-master
c9170d3 
Master (which is Nextcloud 22) doesn't support PHP 7.2 any more.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 added the bug label Feb 17, 2021
@PVince81 PVince81 requested a review from kesselb February 17, 2021 14:09
@PVince81 PVince81 self-assigned this Feb 17, 2021
@PVince81 PVince81 mentioned this pull request Feb 17, 2021
Closed
4 tasks
@PVince81
Copy link
Member Author

PVince81 commented Feb 18, 2021

I've restarted the build. Hopefully now the devcontainer issue should be gone.

But probably it's too early:

% unzip -l latest-master.zip| grep devcont
        0  2021-02-18 00:32   nextcloud/.devcontainer/
      212  2021-02-18 00:32   nextcloud/.devcontainer/setup.sh
     1095  2021-02-18 00:32   nextcloud/.devcontainer/Dockerfile
      346  2021-02-18 00:32   nextcloud/.devcontainer/devcontainer.json
      589  2021-02-18 00:32   nextcloud/.devcontainer/docker-compose.yml
      513  2021-02-18 00:32   nextcloud/.devcontainer/codespace.config.php

@PVince81
Copy link
Member Author

PVince81 commented Feb 22, 2021

I've checked the latest master build and the .devcontainer is gone.
The build has been restarted, expecting green now.

@PVince81
Copy link
Member Author

PVince81 commented Feb 22, 2021

as the download server is currently overloaded, let's try again later...
Curl error: Failed to connect to download.nextcloud.com port 443: Connection timed out (Exception)

@PVince81
Copy link
Member Author

PVince81 commented Feb 26, 2021

restarted again, let's see...

@PVince81
Copy link
Member Author

PVince81 commented Feb 26, 2021

okay, no more timeout, just this:
Version mismatch - Installed: 22.0.0.1 Wanted: 20.0 (Exception)

I guess more adjustments are needed since we increased the version on master, I'll take care...

@PVince81
Update expected master version
e2fcde5 
Signed-off-by: Vincent Petry <[email protected]>
@PVince81
Copy link
Member Author

PVince81 commented Feb 26, 2021

green! it appears that I'm "not authorized to merge this pull request".
can you do it @kesselb ? or someone else ? @nickvergessen @ChristophWurst @juliushaertl

@kesselb kesselb merged commit 7c0e126 into master Feb 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the ci-remove-old branch February 26, 2021 09:31
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 23, 2021

/backport to stable19

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 23, 2021

/backport to stable20

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 23, 2021

/backport to stable21

This was referenced Mar 23, 2021
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes

Assignees

@PVince81 PVince81

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PVince81 @MorrisJobke @kesselb