Do not allow to keep maintenance mode active in web updater #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would allow to mess up the instance and is only recoverable from CLI. If CLI usage is wanted then the updater can also be run from CLI. Signed-off-by: Morris Jobke <[email protected]>
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
delete-merged-branch
bot
deleted the
enh/noid/no-maintenance-mode-active-in-web
branch
This was referenced Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That would allow to mess up the instance and is only recoverable from CLI.
If CLI usage is wanted then the updater can also be run from CLI.
Before there were two buttons (to keep maintenance mode active) and after that the done step had a button "redirect to updater". This is now done automatically.