Skip to content

Conversation

@tcitworld
Copy link
Member

This can be useful in scenarios running non-interactively but wanting to do both things separately

@tcitworld
Copy link
Member Author

Building the phar package seems to update other composer autoloading files as well, so it probably won't pass tests.

@come-nc
Copy link
Collaborator

come-nc commented Feb 6, 2023

Building the phar package seems to update other composer autoloading files as well, so it probably won't pass tests.

Confirmed, but how do we fix that? It’s a composer version problem?

@tcitworld
Copy link
Member Author

tcitworld commented Feb 6, 2023

Yup, composer dump-autoload gives a different output. You could run make updater.phar in another PR to update the vendor contents and the phar file done in #461, then I'll rebase and build here.


Also tests are locked to PHP7.4 which no longer with Nextcloud master. #462

@tcitworld tcitworld mentioned this pull request Feb 6, 2023
This can be useful in scenarios running non-interactively but wanting to do both things separately

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld force-pushed the add-no-upgrade-option branch 2 times, most recently from ecdb366 to 1f936fc Compare February 7, 2023 13:45
Signed-off-by: Thomas Citharel <[email protected]>
@blizzz blizzz merged commit f3afb79 into master Feb 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-no-upgrade-option branch February 7, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants