Skip to content

Conversation

@makoehr
Copy link
Contributor

@makoehr makoehr commented Apr 23, 2023

When running nextcloud with a web hoster it might be necessary to extend .user.ini after each update (e.g. adding memory_limit). To automate this step, an additional config entry may be provided in config.php that specifies the lines to be added to .user.ini.

If the config option 'user_ini_additional_lines' exists, the provided value (string or array of strings) will be added to .user.ini.

@makoehr makoehr force-pushed the extend-user-ini-with-lines-from-configuration branch 2 times, most recently from d58fa17 to 34aba9a Compare April 23, 2023 07:39
@makoehr makoehr changed the title Append config values to .user.ini Config value to allow to extend .user.ini on update Apr 23, 2023
@makoehr makoehr force-pushed the extend-user-ini-with-lines-from-configuration branch from 34aba9a to 4d14bab Compare April 23, 2023 07:46
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 22, 2024
44 tasks
@blizzz blizzz mentioned this pull request Aug 29, 2024
24 tasks
@blizzz blizzz modified the milestones: Nextcloud 30, Nextcloud 31 Sep 4, 2024
@makoehr makoehr requested a review from Altahrim as a code owner January 8, 2025 17:48
@makoehr makoehr marked this pull request as draft May 4, 2025 05:43
@makoehr
Copy link
Contributor Author

makoehr commented May 4, 2025

Hi, could someone do a review on this pull request?

@makoehr makoehr closed this May 4, 2025
@makoehr makoehr reopened this May 4, 2025
@makoehr makoehr marked this pull request as ready for review May 4, 2025 05:50
@makoehr
Copy link
Contributor Author

makoehr commented May 4, 2025

@Altahrim , could you please have a look at this pull request? Thanks.

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry it took so long, just to make sure, because I could not see that anywhere else.
user_ini_additional_lines isn't an official config.php property, no?

If so, before we can move forward with that PR, you'll have to officially add user_ini_additional_lines support on https://github.com/nextcloud/server

@makoehr
Copy link
Contributor Author

makoehr commented Aug 20, 2025

Hey, sorry it took so long, just to make sure, because I could not see that anywhere else. user_ini_additional_lines isn't an official config.php property, no?

If so, before we can move forward with that PR, you'll have to officially add user_ini_additional_lines support on https://github.com/nextcloud/server

Please see nextcloud/server#54552

@skjnldsv skjnldsv force-pushed the extend-user-ini-with-lines-from-configuration branch 2 times, most recently from 79d0df0 to b3abd9d Compare August 21, 2025 08:39
@skjnldsv
Copy link
Member

Thanks Mathias!

I rebased and changed your commits to be compliant with our conventional commits requirements.
I also added some tests

@skjnldsv
Copy link
Member

Btw, please refrain from clicking the update button. It creates merge commits that makes it harder to have a clean commit history :)
If you want to keep your PR up-to-date, it's best to rebase instead 😊

@makoehr
Copy link
Contributor Author

makoehr commented Aug 21, 2025

Thanks Mathias!

I rebased and changed your commits to be compliant with our conventional commits requirements. I also added some tests

Thanks a lot for the support

@skjnldsv skjnldsv force-pushed the extend-user-ini-with-lines-from-configuration branch 2 times, most recently from c302012 to b318478 Compare August 21, 2025 08:46
makoehr and others added 2 commits August 21, 2025 10:47
When running nextcloud with a web hoster it might be necessary
to extend .user.ini after each update (e.g. adding memory_limit).
To automate this step, an additional config entry may be provided
in config.php that specifies the lines to be added to .user.ini.

If the config option 'user_ini_additional_lines' exists, the provided
value (string or array of strings) will be added to .user.ini.

Signed-off-by: Mathias Koehrer <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
@skjnldsv skjnldsv force-pushed the extend-user-ini-with-lines-from-configuration branch from b318478 to a0c5f9f Compare August 21, 2025 08:47
@skjnldsv skjnldsv enabled auto-merge August 21, 2025 09:07
@skjnldsv skjnldsv merged commit 14d6322 into nextcloud:master Aug 21, 2025
22 checks passed
@skjnldsv
Copy link
Member

Took long enough, but thank you @makoehr ! 🙇
We're slowly but surely catching up our backlog :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants