Skip to content

fix(integrity): expect pkg mgmt files #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blizzz wants to merge 8 commits into from
Closed

fix(integrity): expect pkg mgmt files #490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e5a36ce
fix(integrity): expect pkg mgmt files
blizzz Sep 12, 2023
70ca39d
ci(config): test against related NC version
blizzz Sep 13, 2023
c9e29c7
fix(build): add updater.phar with clean version
blizzz Sep 13, 2023
81da230
deps(php): fix php platform and update deps
blizzz Sep 13, 2023
6e8c8f3
ci(deps): set platform and update behat
blizzz Sep 13, 2023
f9cd878
fix: psalm
skjnldsv Jun 7, 2023
2fbf2cd
ci(deps): bump symfony/console to 6.0
blizzz Sep 13, 2023
e1ddf66
fixup! ci(config): test against related NC version
blizzz Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: psalm 
Signed-off-by: John Molakvoæ <[email protected]>
  • Loading branch information
@skjnldsv @blizzz
skjnldsv authored and blizzz committed Sep 13, 2023
commit f9cd8787cb32ae6376873ebdd9a3715979ece95d
8 changes: 7 additions & 1 deletion lib/RecursiveDirectoryIteratorWithoutData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ public function accept(): bool {
'data',
'..',
];
return !(in_array($this->current()->getFilename(), $excludes, true) || $this->current()->isDir());

$current = $this->current();
if (!$current) {
return false;
}

return !(in_array($current->getFilename(), $excludes, true) || $current->isDir());
}
}
2 changes: 1 addition & 1 deletion lib/Updater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ public function createBackup() {
$this->silentLog('[info] end of createBackup()');
}

private function getChangelogURL($versionString) {
private function getChangelogURL(string $versionString) {
$this->silentLog('[info] getChangelogURL()');
$changelogWebsite = 'https://nextcloud.com/changelog/';
$changelogURL = $changelogWebsite . '#' . str_replace('.', '-', $versionString);
Expand Down