fix: Store first level children in an array to avoid problems

Signed-off-by: Côme Chilliet <[email protected]>

lib/Updater.php

@@ -289,21 +289,28 @@ private function getRecursiveDirectoryIterator(string $folder, array $excludedPa
 		if ($handle === false) {
 			throw new \Exception('Could not open '.$folder);
 		}
+
+		/* Store first level children in an array to avoid trouble if changes happen while iterating */
+		$children = [];
 		while ($name = readdir($handle)) {
 			if (in_array($name, ['.', '..'])) {
 				continue;
 			}
 			if (isset($exclusions[$name])) {
 				continue;
 			}
+			$children[] = $name;
+		}
+
+		closedir($handle);
+
+		foreach ($children as $name) {
 			$path = $folder.'/'.$name;
 			if (is_dir($path)) {
 				yield from $this->getRecursiveDirectoryIterator($path, []);
 			}
 			yield $path => new \SplFileInfo($path);
 		}
-
-		closedir($handle);
 	}
 
 	/**