Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented May 15, 2024

Backport of #556

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested a review from nickvergessen May 15, 2024 08:30
@backportbot backportbot bot added this to the Nextcloud 29.0.1 milestone May 15, 2024
@nickvergessen nickvergessen force-pushed the backport/556/stable29 branch from 9293bcb to c76fcaf Compare May 15, 2024 08:35
@nickvergessen nickvergessen marked this pull request as ready for review May 15, 2024 08:38
@blizzz
Copy link
Member

blizzz commented May 15, 2024

[✘] Check for expected files failed
      The following extra files have been found:
          LICENSES
          .reuse

This is 30 only, and the updater master branch deals with it correctly.

@blizzz blizzz requested a review from Altahrim May 15, 2024 09:54
@skjnldsv skjnldsv mentioned this pull request May 15, 2024
21 tasks
@nickvergessen
Copy link
Member

This is 30 only, and the updater master branch deals with it correctly.

I guess it should not test against master in stable branches... same for the PHP versions

@blizzz
Copy link
Member

blizzz commented May 15, 2024

@Altahrim and I discussed that today and we think the same.

@nickvergessen nickvergessen merged commit bbb3fee into stable29 May 16, 2024
@nickvergessen nickvergessen deleted the backport/556/stable29 branch May 16, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants