Skip to content

[stable27] fix: Correctly check result of function #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
May 16, 2024
Merged

[stable27] fix: Correctly check result of function #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Correctly check result of function 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed May 15, 2024
commit 4890017c91ececf9c26264580be96c6dd7911071
4 changes: 2 additions & 2 deletions index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,12 +688,12 @@ public function verifyIntegrity() {
-----END CERTIFICATE-----
EOF;

$validSignature = (bool)openssl_verify(
$validSignature = openssl_verify(
file_get_contents($this->getDownloadedFilePath()),
base64_decode($response['signature']),
$certificate,
OPENSSL_ALGO_SHA512
);
) === 1;

if ($validSignature === false) {
throw new \Exception('Signature of update is not valid');
Expand Down
4 changes: 2 additions & 2 deletions lib/Updater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,12 +652,12 @@ public function verifyIntegrity() {
-----END CERTIFICATE-----
EOF;

$validSignature = (bool)openssl_verify(
$validSignature = openssl_verify(
file_get_contents($this->getDownloadedFilePath()),
base64_decode($response['signature']),
$certificate,
OPENSSL_ALGO_SHA512
);
) === 1;

if ($validSignature === false) {
throw new \Exception('Signature of update is not valid');
Expand Down
Binary file modified updater.phar
View file
Open in desktop
Binary file not shown.