Skip to content

[stable31] fix: lock config file when reading and writing #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
backportbot wants to merge 5 commits into from
Closed

[stable31] fix: lock config file when reading and writing #604

backportbot wants to merge 5 commits into from

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Feb 10, 2025 •
edited by blizzz
Loading

Backport of #579

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from blizzz and come-nc February 10, 2025 20:10
@backportbot backportbot bot added this to the Nextcloud 31 milestone Feb 10, 2025
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 31.0.1 Feb 26, 2025
blizzz and others added 3 commits March 10, 2025 20:19
@blizzz
fix: lock config file when reading and writing
7a79141 
this is in accordance how the config files are handled in \OC\Config

Signed-off-by: Arthur Schiwon <[email protected]>
@come-nc @blizzz
fix: Improve Exception messages and avoid duplicated code
b6882e1 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc @blizzz
chore: Adapt cli test to new output
b48715d 
Signed-off-by: Côme Chilliet <[email protected]>
@blizzz blizzz force-pushed the backport/579/stable31 branch 4 times, most recently from 6d04f47 to 88d7370 Compare March 10, 2025 19:36
@blizzz
refactor: adapt to stable31
c694f97 
Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz force-pushed the backport/579/stable31 branch from 88d7370 to 963c284 Compare March 10, 2025 19:41
@blizzz blizzz force-pushed the backport/579/stable31 branch from 963c284 to feb75d7 Compare March 10, 2025 19:59
@blizzz
Copy link
Member

blizzz commented Mar 10, 2025

Cannot get the InstalledVersions.php to match in the updater.phar. Could it be that i have PHP 8.2.26, not 8.2.27? Don'T like to believe it, but composer versions are identical.

@come-nc
Copy link
Collaborator

come-nc commented Mar 11, 2025

Cannot get the InstalledVersions.php to match in the updater.phar. Could it be that i have PHP 8.2.26, not 8.2.27? Don'T like to believe it, but composer versions are identical.

I’m unsure, I would expect only composer version to matter.

@blizzz blizzz removed this from the Nextcloud 31.0.5 milestone May 6, 2025
@blizzz blizzz added this to the Nextcloud 31.0.6 milestone May 6, 2025
@skjnldsv skjnldsv closed this Aug 21, 2025
@skjnldsv skjnldsv deleted the backport/579/stable31 branch August 21, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc Awaiting requested review from come-nc

@blizzz blizzz Awaiting requested review from blizzz

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim will be requested when the pull request is marked ready for review Altahrim is a code owner

Assignees

@blizzz blizzz

Labels

3. to review bug

Projects

None yet

Milestone

Nextcloud 31.0.9

Development

Successfully merging this pull request may close these issues.

5 participants

@blizzz @come-nc @Altahrim @skjnldsv