fix: silence rename warnings #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
approved these changes
May 5, 2025
skjnldsv
force-pushed
the
fix/silence-rename-warnings
branch
from
58c9e1f to
87bf56e
Compare
skjnldsv
approved these changes
Jun 5, 2025
Signed-off-by: Richard Steinmetz <[email protected]>
skjnldsv
force-pushed
the
fix/silence-rename-warnings
branch
from
87bf56e to
da70ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the main Nextcloud and data folder are on separate devices, PHP will automatically fall back to copying and removing the source instead of renaming. However, it will print verbose warnings.
We should silence those warnings. An exception will be thrown if the rename actually fails.
Example
However after all the errors did it report the move as successful.