-
Notifications
You must be signed in to change notification settings - Fork 8
Add export estimation #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ff4986d to
6ed2e8e
Compare
|
|
@Pytal I think the API should expose getting the export size estimate as it may be useful for several things in UI, showing the estimate is a good idea in my opinion, and later we may want to compare it with current export size to have some kind of a progress bar? (Maybe not as a progress bar but as current size vs expected size at least to have a feeling of how it goes.) |
|
@come-nc let's discuss the details more post release freeze 🚀 |
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
6ed2e8e to
f8c2260
Compare
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Avoids having to query multiple endpoints on the client for closely related information Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
f8c2260 to
3858dd9
Compare
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
HTTP query example |
|
@come-nc please review and since you can't approve as the author just comment instead |
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
48ae999 to
85c551b
Compare
Approved |
|
/backport to stable24 |
GETwith query params for endpointRequires:
Add a controller method to get an estimation of export size before exporting.