Skip to content

Show estimated export size and display exportability warnings #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 12 commits into from
Jun 10, 2022
Merged

Show estimated export size and display exportability warnings #136

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
64c7cb8
Add function to check exportability
Pytal Apr 30, 2022
867933b
Update error message
Pytal Apr 30, 2022
e65a172
Update error message
Pytal Apr 30, 2022
83f977f
Check if data is exportable and display warnings
Pytal Apr 30, 2022
129b525
Use error handler
Pytal Apr 30, 2022
8831ddb
Fix eslint errors
Pytal Apr 30, 2022
30533f2
Handle empty array
Pytal Jun 3, 2022
129e013
Display estimated export size
Pytal Jun 4, 2022
c1f4d48
Use MiB in not exportable message
Pytal Jun 7, 2022
1e51add
Build js
Pytal Jun 7, 2022
300a885
Update endpoint data handling
Pytal Jun 8, 2022
23ba2a0
Round to a whole number and set a minimum
Pytal Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Round to a whole number and set a minimum 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal
Pytal committed Jun 10, 2022
commit 23ba2a0fc379f51d502d897481049241c23a466d
4 changes: 2 additions & 2 deletions lib/Controller/ApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,8 @@ public function exportable(?array $migrators): DataResponse {

try {
$size = $this->migrationService->estimateExportSize($user, $migrators);
// Convert to MiB and round to one significant digit after the decimal point
$roundedSize = round($size / 1024, 1);
// Round and convert to MiB
$roundedSize = max(1, round($size / 1024));
} catch (UserMigrationException $e) {
throw new OCSException($e->getMessage());
}
Expand Down