Skip to content

Migration orchestration #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 12 commits into from
Feb 22, 2022
Merged

Migration orchestration #27

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7d2d8aa
Run exports and imports of registered migrators
Pytal Feb 4, 2022
dffce83
Extend export destination as defined by the public interface
Pytal Feb 9, 2022
ebe7931
Suppress psalm errors
Pytal Feb 15, 2022
c1b931a
Add a stubs file for Coordinator
come-nc Feb 15, 2022
4f7dde7
Update baseline
come-nc Feb 15, 2022
245ad9d
Export migrator versions in the export archive and check compatibilit…
come-nc Feb 14, 2022
474c21b
Moved the trait to server repository
come-nc Feb 14, 2022
cc8393b
Adapt to version handling changes in core interfaces
come-nc Feb 15, 2022
77c4fc8
Trait property default value cannot be overridden
come-nc Feb 15, 2022
60e60ec
Adapt to changes in core
come-nc Feb 21, 2022
b6be1e1
update christophwurst/nextcloud
come-nc Feb 22, 2022
82469c0
Update baseline
come-nc Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adapt to changes in core 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Feb 21, 2022
commit 60e60ec812103c4951045ad7de4e7edfb6dc0561
8 changes: 8 additions & 0 deletions lib/ImportSource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,14 @@ public function getMigratorVersions(): array {
return $this->migratorVersions;
}

/**
* {@inheritDoc}
*/
public function getMigratorVersion(string $migrator): ?int {
$versions = $this->getMigratorVersions();
return $versions[$migrator] ?? null;
}

/**
* {@inheritDoc}
*/
Expand Down
6 changes: 3 additions & 3 deletions lib/Service/UserMigrationService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ public function import(string $path, ?OutputInterface $output = null): void {
foreach ($context->getUserMigrators() as $migratorRegistration) {
/** @var IMigrator $migrator */
$migrator = $this->container->get($migratorRegistration->getService());
if (!$migrator->canImport($importSource, $migratorVersions[get_class($migrator)] ?? null)) {
throw new UserMigrationException("Version ".($migratorVersions[get_class($migrator)] ?? 'null')." for migrator ".get_class($migrator)." is not compatible");
if (!$migrator->canImport($importSource)) {
throw new UserMigrationException("Version ".($importSource->getMigratorVersion(get_class($migrator)) ?? 'null')." for migrator ".get_class($migrator)." is not supported");
}
}

Expand All @@ -192,7 +192,7 @@ public function import(string $path, ?OutputInterface $output = null): void {
foreach ($context->getUserMigrators() as $migratorRegistration) {
/** @var IMigrator $migrator */
$migrator = $this->container->get($migratorRegistration->getService());
$migrator->import($user, $importSource, $output, $migratorVersions[get_class($migrator)] ?? null);
$migrator->import($user, $importSource, $output);
}

$uid = $user->getUID();
Expand Down