Skip to content

[main] Update nextcloud/ocp dependency #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 2 commits into from
May 3, 2023
Merged

[main] Update nextcloud/ocp dependency #406

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
268a4eb
chore(dev-deps): Bump nextcloud/ocp package
nextcloud-command May 3, 2023
862a8bd
fix(ci): Cast to int
Pytal May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(ci): Cast to int 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal
Pytal committed May 3, 2023
commit 862a8bdd6ab1262bff47e258d935337ef89daa70
2 changes: 1 addition & 1 deletion lib/Migrator/FilesMigrator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ private function estimateFolderSize(Folder $folder, ?callable $nodeFilter = null
$size += $this->estimateFolderSize($node, $nodeFilter);
}
}
return $size;
return (int)$size;
Copy link
Collaborator

@come-nc come-nc May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fail on 32bits for more than 4GB (or 2GB because signed?).
Should we move all int to int|float for filesizes 32bit support?

Copy link
Collaborator

@come-nc come-nc May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pytal ^

Copy link
Member

@Pytal Pytal May 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 yep 2GB max cause signed https://www.php.net/manual/en/reserved.constants.php#reserved.constants.core

32-bit support added in:

}

/**
Expand Down