Skip to content

Use migrators id string instead of class name #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
come-nc merged 1 commit into from
Apr 11, 2022
Merged

Use migrators id string instead of class name #80

come-nc merged 1 commit into from
Apr 11, 2022

Conversation

@come-nc
Copy link
Collaborator

@come-nc come-nc commented Apr 11, 2022 •
edited by Pytal
Loading

@come-nc come-nc added the 3. to review Waiting for reviews label Apr 11, 2022
@come-nc come-nc self-assigned this Apr 11, 2022
@come-nc come-nc requested review from a team, PVince81, icewind1991 and skjnldsv and removed request for a team April 11, 2022 08:59
@come-nc come-nc added this to the 0.1 milestone Apr 11, 2022
PVince81
PVince81 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

PVince81 commented Apr 11, 2022

static check failed

@come-nc come-nc merged commit 19e221d into main Apr 11, 2022
@come-nc come-nc deleted the fix/adapt-code-to-id-change branch April 11, 2022 09:50
@come-nc
Copy link
Collaborator Author

come-nc commented Apr 11, 2022

static check failed

This is related to OCP local API not being up to date with upstream, should fix itself with time.

@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@come-nc come-nc

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@come-nc @PVince81 @CarlSchwan