Skip to content

Conversation

@saw-jan
Copy link
Contributor

@saw-jan saw-jan commented Apr 10, 2025

Allow requesting scope when using ExchangedTokenRequestedEvent event.

Usage:

$scopes = ["myscope1", "myscope2"];

$event = new ExchangedTokenRequestedEvent($targetAudience, $scopes);

Part of #1091

@saw-jan saw-jan force-pushed the feat/allow-scope-request-exchanged-event branch from 0ffca20 to ad58221 Compare April 11, 2025 06:20
@saw-jan
Copy link
Contributor Author

saw-jan commented Apr 11, 2025

@julien-nc Could you review it?

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be nicer to pass the extra scopes as an array that would turned into a string in the end like implode(' ', $extraScopes). Wdyt?

@saw-jan
Copy link
Contributor Author

saw-jan commented Apr 11, 2025

Looks good. It would be nicer to pass the extra scopes as an array that would turned into a string in the end like implode(' ', $extraScopes). Wdyt?

That would also be nice. Let me change it to array. Thanks

@saw-jan saw-jan force-pushed the feat/allow-scope-request-exchanged-event branch from ad58221 to 5ee9995 Compare April 11, 2025 11:42
@saw-jan saw-jan force-pushed the feat/allow-scope-request-exchanged-event branch from 5ee9995 to ae83c0d Compare April 11, 2025 11:43
@saw-jan
Copy link
Contributor Author

saw-jan commented Apr 11, 2025

Looks good. It would be nicer to pass the extra scopes as an array that would turned into a string in the end like implode(' ', $extraScopes). Wdyt?

Done!

@saw-jan
Copy link
Contributor Author

saw-jan commented Apr 14, 2025

@julien-nc Please merge this if okay to do so. I have no permissions to merge it

@julien-nc julien-nc merged commit cf5ccd1 into nextcloud:main Apr 23, 2025
44 checks passed
@julien-nc julien-nc mentioned this pull request Apr 24, 2025
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants