-
Notifications
You must be signed in to change notification settings - Fork 44
feat: allow requesting scopes when using ExchangedTokenRequestedEvent event #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow requesting scopes when using ExchangedTokenRequestedEvent event #1099
Conversation
0ffca20 to
ad58221
Compare
|
@julien-nc Could you review it? |
julien-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It would be nicer to pass the extra scopes as an array that would turned into a string in the end like implode(' ', $extraScopes). Wdyt?
That would also be nice. Let me change it to array. Thanks |
ad58221 to
5ee9995
Compare
… event Signed-off-by: Saw-jan <[email protected]>
5ee9995 to
ae83c0d
Compare
Done! |
|
@julien-nc Please merge this if okay to do so. I have no permissions to merge it |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Allow requesting scope when using
ExchangedTokenRequestedEventevent.Usage:
Part of #1091