Improve the NC error page when the IdP auth fails #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janepie
approved these changes
Jun 20, 2025
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/template-code-response-idp-error
branch
from
a1c8ce3 to
a715488
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the IdP redirects to the user_oidc "code" endpoint with an error, we used to display a raw JSON response. We can return a real error page there with a nicer user-facing error description. The real error is logged with a "warning" level.
Since 32, the "403" template contains a button to go back to the login page. Even better for us.