Add provider deletion confirmation #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edward-ly
reviewed
Jun 26, 2025
src/components/AdminSettings.vue
Outdated
| {{ t('user_oidc', 'Cancel') }} | ||
| </NcButton> | ||
| <NcButton | ||
| variant="warning" |
Contributor
There was a problem hiding this comment.
Why the warning variant rather than error? The red color makes more sense to me, personally, even if it's not technically an "error".
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/1142/confirm-deletion
branch
from
1e8bb4a to
e9d602f
Compare
edward-ly
approved these changes
Jun 30, 2025
Comment on lines
+222
to
+225
| if (this.providerToDelete) { | ||
| return t('user_oidc', 'Are you sure you want to delete the provider "{providerName}"?', { providerName: this.providerToDelete.identifier }) | ||
| } | ||
| return '' |
Contributor
There was a problem hiding this comment.
Suggested change
| if (this.providerToDelete) { | |
| return t('user_oidc', 'Are you sure you want to delete the provider "{providerName}"?', { providerName: this.providerToDelete.identifier }) | |
| } | |
| return '' | |
| if (!this.providerToDelete) { | |
| return '' | |
| } | |
| return t('user_oidc', 'Are you sure you want to delete the provider "{providerName}"?', { providerName: this.providerToDelete.identifier }) |
a small refactor to reduce the line length, but it's up to you, LGTM otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1142
Display a dialog when clicking on the delete button of a provider.
Also fix the prop passed to the edition NcModal to avoid displaying the close button in it.