-
Notifications
You must be signed in to change notification settings - Fork 44
feat: allow self-signed SSL verification and support for oidc prompt #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
julien-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you. Can you remove all the formatting changes and make sure your additions use the same code style?
You can run composer run cs:fix if you want.
I will try this out and give another review.
|
Works fine with Keycloak. I checked with prompt set to none, login and consent (with Not sure how the user is supposed to log in when prompt is none. It seems like the IdP expects the credentials in the authorization request because it returns Maybe you should add an extra detail in the README: For the consent page to be displayed with Keycloak, |
|
@elyerr hi! would you be up for doing the changes or would you prefer if we finish the pr? |
44f754e to
6198a6c
Compare
|
@elyerr Thanks for the adjustment. One last thing: the |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Elvis Yerel Roman <[email protected]>
Signed-off-by: Elvis Yerel Roman <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Elvis Yerel Roman <[email protected]> Signed-off-by: Julien Veyssier <[email protected]>
fa5a516 to
6beb6da
Compare
Signed-off-by: Julien Veyssier <[email protected]>
|
This broke my Nextcloud instance's intended behavior. What am I supposed to do here when I just want it to act the way it did before this PR?? |
|
@YeapGuy, In OAuth2 and OpenID Connect, the use of these three prompts (consent, login, none) is a standard. |
Pull Request: Add support for self-signed certificates and custom OIDC prompt
Summary
This PR introduces two key improvements to enhance development and integration flexibility with custom OAuth2/OIDC providers:
Features Added
Custom OIDC prompt support:
Adds support for the standard OIDC prompt values: none, login, and consent.
Introduces a custom internal prompt designed specifically for private applications using OAuth2 Passport Server.
Documentation for this prompt is available here: Prompts Supported
Note
Use of self-signed certificates is intended only for development or trusted internal networks. It should be disabled in production environments to ensure secure communication.