Make sure to logout in the IdP when single-logout didn't find the provider #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mode, use the one and only provider to make sure we logout in the IdP and avoid being immediately logged in NC again Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
fix/noid/sso-logout-no-session-data
branch
from
39c6ab3 to
23e38a4
Compare
This was referenced Jul 25, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In single-logout, if the provider is not found (because the Php session died for example) and we are in SSO mode, use the one and only provider to make sure we logout in the IdP and avoid being immediately logged in NC again.