Fix backchannel logout when no SID is set in the logout token #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
fix/1183/fix-backchannel-sid-sub-logic
branch
2 times, most recently
from
41aac8f to
1df676a
Compare
…b, sub. If only sub is set: kill all sessions for this sub Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
fix/1183/fix-backchannel-sid-sub-logic
branch
from
1df676a to
260d9d7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle those logout token cases:
According to the specs, if there is no SID, there should be a SUB and this means all the sessions related with this sub should be terminated.
closes #1183