only call handleApacheAuth() if we login via environment variables #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the audit-log app is enabled and log level is set to "1". We have multiple failed login attempts in the audit.log during every page reload if the user is logged in via saml. This happens because we always load the app and call
handleApacheAuth()while this should be only needed for login via environment variables.With this fix we reduce this "login attempt" messages to one per page reload. The remaining one comes from here https://github.com/nextcloud/server/blob/master/apps/dav/lib/Connector/Sabre/Auth.php#L231.
I have no idea how to avoid this one. Any idea?
cc @rullzer