Skip to content

Conversation

@schiessle
Copy link
Member

@schiessle schiessle commented Oct 29, 2018

If the audit-log app is enabled and log level is set to "1". We have multiple failed login attempts in the audit.log during every page reload if the user is logged in via saml. This happens because we always load the app and call handleApacheAuth() while this should be only needed for login via environment variables.

With this fix we reduce this "login attempt" messages to one per page reload. The remaining one comes from here https://github.com/nextcloud/server/blob/master/apps/dav/lib/Connector/Sabre/Auth.php#L231.

{"reqId":"vxjRSaLGZJZoU8zcS0tn","level":1,"time":"2018-10-29T22:10:20+00:00","remoteAddr":"127.0.0.1","user":"Schiessle","app":"admin_audit","method":"PROPFIND","url":"\/server\/remote.php\/dav\/files\/Schiessle\/","message":"Login attempt: \"Schiessle\"","userAgent":"Mozilla\/5.0 (X11; Linux x86_64; rv:63.0) Gecko\/20100101 Firefox\/63.0","version":"14.0.3.0"}

I have no idea how to avoid this one. Any idea?

cc @rullzer

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants