Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Mar 1, 2022

@blizzz
Copy link
Member Author

blizzz commented Mar 18, 2022

Tests are still not stable, and sometimes fail with:

[18/Mar/2022:15:20:22.704103023 +0000] - ERR - add_new_slapd_process - Unable to start slapd because it is already running as process 9
[18/Mar/2022:15:20:22.705794092 +0000] - CRIT - main - Shutting down due to possible conflicts with other slapd processes

However there is nothing that would start the same thing twice. I even removed the start.sh as CMD from the dockerfile in nextcloud/docker-ci#359, without effect. I thought for a weird reason it could be dependent on the host system (some workers are still on Ubuntu 18.04), but when doing it manually i could not reproduce it. Nor can i locally.

@PVince81
Copy link
Member

@blizzz I searched online for that message, and found this: https://pagure.io/389-ds-base/issue/50989

are we stopping and restarting that service repeatedly ? maybe some lock cleanup missing ?

@PVince81
Copy link
Member

ok, so it seems there's a solution already: nextcloud/docker-ci#359 (comment)

@PVince81
Copy link
Member

I've restarted the build and hope it will pick up the change there

@artonge artonge force-pushed the enh/noid/inttests80 branch from 08a03c5 to 5d4b2cb Compare March 28, 2022 09:50
@artonge
Copy link

artonge commented Mar 28, 2022

Solution seems to work 🎉
Applying it to 8.0, rebuilding images

@artonge artonge force-pushed the enh/noid/inttests80 branch from 5d4b2cb to be706a3 Compare March 28, 2022 11:13
@artonge
Copy link

artonge commented Mar 28, 2022

All green, @blizzz DCO and fixup bot is failing Done

@artonge artonge force-pushed the enh/noid/inttests80 branch 2 times, most recently from 3b3a14d to a62f9d2 Compare March 28, 2022 11:44
Copy link

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove vendor files?

@blizzz
Copy link
Member Author

blizzz commented Apr 7, 2022

Remove vendor files?

sheesh, that opened another pandora's box

@blizzz blizzz force-pushed the enh/noid/inttests80 branch from 6a491ce to c628259 Compare April 7, 2022 14:17
@blizzz blizzz force-pushed the enh/noid/inttests80 branch from c628259 to af17578 Compare April 7, 2022 15:01
@blizzz
Copy link
Member Author

blizzz commented Apr 7, 2022

Mh, I am feeling to split the last commit from here and unifiy 3rdparty and vendor. Otherwise people will be mad to install it for it has to be composer install twice. This does not need to be another blocker.

@blizzz blizzz force-pushed the enh/noid/inttests80 branch from af17578 to 3ecd49e Compare April 7, 2022 16:17
@blizzz
Copy link
Member Author

blizzz commented Apr 7, 2022

@artonge vendor file removal at #594

@blizzz blizzz requested a review from artonge April 7, 2022 16:19
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz merged commit 2d56627 into master Apr 7, 2022
@blizzz blizzz deleted the enh/noid/inttests80 branch April 7, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants