-
Notifications
You must be signed in to change notification settings - Fork 81
use PHP 8.0 image for master integration tests #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a98f5ad to
9c0efaa
Compare
61d166f to
08a03c5
Compare
640ea28 to
08a03c5
Compare
|
Tests are still not stable, and sometimes fail with: However there is nothing that would start the same thing twice. I even removed the start.sh as CMD from the dockerfile in nextcloud/docker-ci#359, without effect. I thought for a weird reason it could be dependent on the host system (some workers are still on Ubuntu 18.04), but when doing it manually i could not reproduce it. Nor can i locally. |
|
@blizzz I searched online for that message, and found this: https://pagure.io/389-ds-base/issue/50989 are we stopping and restarting that service repeatedly ? maybe some lock cleanup missing ? |
|
ok, so it seems there's a solution already: nextcloud/docker-ci#359 (comment) |
|
I've restarted the build and hope it will pick up the change there |
08a03c5 to
5d4b2cb
Compare
|
Solution seems to work 🎉 |
5d4b2cb to
be706a3
Compare
|
All green, |
3b3a14d to
a62f9d2
Compare
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove vendor files?
sheesh, that opened another pandora's box |
6a491ce to
c628259
Compare
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
c628259 to
af17578
Compare
|
Mh, I am feeling to split the last commit from here and unifiy 3rdparty and vendor. Otherwise people will be mad to install it for it has to be composer install twice. This does not need to be another blocker. |
af17578 to
3ecd49e
Compare
CarlSchwan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Uh oh!
There was an error while loading. Please reload this page.