build(deps): bump @nextcloud/vue from 4.3.0 to 5.0.0 #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
3. to review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
/compile amend / |
nextcloud-command
force-pushed
the
dependabot/npm_and_yarn/nextcloud/vue-5.0.0
branch
from
ec31f7b to
87e825d
Compare
Member
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/nextcloud/vue-5.0.0
branch
from
87e825d to
b34ab5f
Compare
Member
|
/rebase |
nextcloud-command
force-pushed
the
dependabot/npm_and_yarn/nextcloud/vue-5.0.0
branch
from
b34ab5f to
cb30adc
Compare
Member
|
/rebase |
nextcloud-command
force-pushed
the
dependabot/npm_and_yarn/nextcloud/vue-5.0.0
branch
from
cb30adc to
adc36bd
Compare
Member
|
/compile amend / |
nextcloud-command
force-pushed
the
dependabot/npm_and_yarn/nextcloud/vue-5.0.0
branch
from
adc36bd to
472e705
Compare
szaimen
reviewed
Feb 22, 2022
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
I guess we should verify if the modal sizes still look good?
szaimen
force-pushed
the
dependabot/npm_and_yarn/nextcloud/vue-5.0.0
branch
from
a0626d3 to
497f12d
Compare
Contributor
|
/compile amend / |
szaimen
approved these changes
Feb 23, 2022
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
lgtm now 👍
Verified with a mp4, flac and jpg file
szaimen
added
4. to release
Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 4.3.0 to 5.0.0. - [Release notes](https://github.com/nextcloud/nextcloud-vue/releases) - [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md) - [Commits](nextcloud-libraries/nextcloud-vue@v4.3.0...v5.0.0) --- updated-dependencies: - dependency-name: "@nextcloud/vue" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
dependabot/npm_and_yarn/nextcloud/vue-5.0.0
branch
from
497f12d to
281625d
Compare
Contributor
|
@skjnldsv do you mind fixing cypress? (Not sure how to do that) |
Member
|
/rebase |
Member
cypress-video5f97c7af-51b6-46bf-a341-dba1a2e974d1.mp4 |
Member
|
To check if the selectors are the same wince the last update of @nc/vue |
Contributor
|
okay, I guess this is then a bug in vue 5.0? But should not be related to the modal change, as far as I understand... |
Contributor
|
@skjnldsv why is cypress suddenly green? |
Member
Restarted |
skjnldsv
reviewed
Apr 29, 2022
| <template> | ||
| <Modal v-if="initiated || currentFile.modal" | ||
| id="viewer" | ||
| size="large" |
Member
There was a problem hiding this comment.
This should have been full, this is a regression
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Oh I see. Do you want to create a pr with a fix or shall I?
Member
There was a problem hiding this comment.
I'm on it, there are lots of issues we missed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @nextcloud/vue from 4.3.0 to 5.0.0.
Release notes
Sourced from
@nextcloud/vue's releases.Changelog
Sourced from
@nextcloud/vue's changelog.Commits
6c7ef0bMerge pull request #2488 from nextcloud/v5.0.0d7bb77cBump version to v5.0.09c2688fMerge pull request #2486 from nextcloud/bugfix/2484/limit-avatar-requests6b85dc9Merge pull request #2482 from nextcloud/dependabot/npm_and_yarn/jest-27.5.15e4e8e4Bump jest from 27.5.0 to 27.5.129d3ac9Merge pull request #2470 from nextcloud/translations_l10n-messages-pot--maste...32dea84Merge pull request #2487 from nextcloud/translations_l10n-messages-pot--maste...32a996dTranslate /l10n/messages.pot in pl1e54980Limit avatar request sizes to 64 and 512 pixelcd0a9e3Merge pull request #2483 from nextcloud/fix/5987-create_submailbox_in_submail...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)