Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Aug 18, 2022

Called like

  const fileInfo = {
	filename: '/path/to/file.jpg',
	basename: 'file.jpg',
	mime: 'image/jpeg',
	etag: 'xyz987',
	hasPreview: true,
	fileid: 13579,
  }
  OCA.Viewer.open({
	fileinfo: fileInfo,
	list: [fileInfo],
  })
  • Adjust open so it can work with a path or a given fileInfo -> fetch file info only for paths
  • Get rid of url file info property and supply the non-dav URL as filename source
  • Specify required file info properties
  • Update readme documentation
  • Adjust specific viewer extensions, if necessary
  • Follow-up: get rid of unused yet required etag property

@skjnldsv
Copy link
Member

@matiasdelellis why the laughing emoji? 😁

@skjnldsv skjnldsv force-pushed the enhancement/non-dav-files branch 3 times, most recently from 733cee7 to 011d2a0 Compare August 19, 2022 19:09
@ChristophWurst ChristophWurst force-pushed the enhancement/non-dav-files branch from 4a17a1b to abdae64 Compare August 23, 2022 12:07
@ChristophWurst ChristophWurst requested a review from st3iny August 23, 2022 12:30
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 23, 2022
@ChristophWurst ChristophWurst marked this pull request as ready for review August 23, 2022 13:26
@skjnldsv
Copy link
Member

/rebase

@skjnldsv skjnldsv enabled auto-merge August 23, 2022 14:18
@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 23, 2022
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the enhancement/non-dav-files branch from abdae64 to a05dbf3 Compare August 23, 2022 14:21
@skjnldsv skjnldsv merged commit e5e0bb6 into master Aug 23, 2022
@skjnldsv skjnldsv deleted the enhancement/non-dav-files branch August 23, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

Development

Successfully merging this pull request may close these issues.

3 participants