Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 21, 2022

Simplify our usage and overrides of the plyr theme to be closer to the lib

Video (default primary, light theme) Audio (default primary, light theme)
Peek 21-08-2022 19-33 Capture d’écran_2022-08-21_19-28-10
Dark primary Bright primary
Peek 21-08-2022 19-35 Peek 21-08-2022 19-34

@skjnldsv skjnldsv self-assigned this Aug 21, 2022
@skjnldsv skjnldsv requested review from a team, PVince81, Pytal and szaimen and removed request for a team August 21, 2022 17:28
@skjnldsv skjnldsv added design Related to the design 3. to review Waiting for reviews technical debt Technical issue labels Aug 21, 2022
@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Aug 21, 2022
@skjnldsv skjnldsv force-pushed the feat/plyr-design-update branch from ccb4665 to 07bb8ec Compare August 21, 2022 17:36
@skjnldsv skjnldsv requested a review from szaimen August 23, 2022 06:45
@skjnldsv skjnldsv force-pushed the feat/plyr-design-update branch from 07bb8ec to e51de66 Compare August 23, 2022 07:01
@skjnldsv
Copy link
Member Author

/rebase

@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv skjnldsv force-pushed the feat/plyr-design-update branch from 198aca7 to 9d310fb Compare August 23, 2022 08:22
@skjnldsv skjnldsv requested a review from artonge August 23, 2022 08:22
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me then

Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv force-pushed the feat/plyr-design-update branch from 9d310fb to b6f548e Compare August 23, 2022 09:34
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 23, 2022
@skjnldsv skjnldsv enabled auto-merge August 23, 2022 09:55
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv force-pushed the feat/plyr-design-update branch from 22f0a20 to 0a91024 Compare August 23, 2022 10:40
@skjnldsv skjnldsv merged commit da6d20e into master Aug 23, 2022
@skjnldsv skjnldsv deleted the feat/plyr-design-update branch August 23, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish design Related to the design technical debt Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants