-
Notifications
You must be signed in to change notification settings - Fork 60
Stop encoding sidebar path #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
66ffcec to
bdb46cf
Compare
|
/backport to stable25 |
|
Done, added cypress tests too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I do not have time to check if it actually works 😅 .
Just a reminder to also check if PDF's can still be opened (It should but it would be good to validate), the alste time I messed with paths here, it broke the PDF viewer for some users.
|
Seems like something is off anyway xD |
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
bdb46cf to
4c80e07
Compare
|
Will the backport work? 🙏 |
|
It's a miracle! 🎄 |
Fix #1465
Let's see if other areas exploded because of this
References:
viewer/src/views/Viewer.vue
Lines 907 to 914 in a1e581d
viewer/src/views/Viewer.vue
Lines 293 to 295 in a1e581d
https://github.com/nextcloud/server/blob/b9bbb25771fc704d0f5a9de7bc2ae0cae73cf81b/apps/files/src/views/Sidebar.vue#L155