Add composer autoloader #1544
Merged
Add composer autoloader #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
3. to review
Member
This is a shipped app, so there are no build steps allowed. You will have to vendor the |
Member
|
See also the additional context in #1535. |
Member
|
Looks good. Did you force add the files? Adjust .gitignore to no longer ignore the added vendor/autoload.php and vendor/composer/* |
Contributor
Author
|
It's in a new composer folder, not in the vendor dir on suggestion by @juliushaertl |
juliusknorr
approved these changes
Feb 10, 2023
Member
|
php-cs-fixer should ignore the composer directory. |
miaulalala
force-pushed
the
enh/add-autoloader-classes
branch
from
0bfd733 to
f7ac6eb
Compare
miaulalala
commented
Feb 13, 2023
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
enh/add-autoloader-classes
branch
from
480967d to
495060e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535
Signed-off-by: Anna Larch [email protected]
@ChristophWurst I added the autoloader class according to the docs. Is there anything else I need to do?