Skip to content

[stable26] fix enter key in text input in image editor #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 1 commit into from
Mar 30, 2023
Merged

[stable26] fix enter key in text input in image editor #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/viewer-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/viewer-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion src/components/ImageEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,10 @@ export default {

// Key Handlers, override default Viewer arrow and escape key
handleKeydown(event) {
event.stopImmediatePropagation()
// Enter needs to be reached through as otherwise saving text does not work
if (event.key !== 'Enter') {
event.stopImmediatePropagation()
}
// escape key
if (event.key === 'Escape') {
// Since we cannot call the closeMethod and know if there
Expand Down