-
Notifications
You must be signed in to change notification settings - Fork 60
Fix size of progress container #1706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix size of progress container #1706
Conversation
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for @skjnldsv opinion before merging
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming the controls are still ok on very small screens like #1351
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, not really fixed, please try with a window width of 320px (mobile).
Maybe we should just hide the volume bar, since mobile have their own volume keys ?
good idea! done |
16ff689 to
4a9c388
Compare
This comment was marked as resolved.
This comment was marked as resolved.
4a9c388 to
3dccd84
Compare
|
/backport to stable25 |
|
/backport to stable26 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
3dccd84 to
48054b4
Compare
|
Seems like an outdated lockfile, no clue why |
48054b4 to
bffd39d
Compare
Signed-off-by: julia.kirschenheuter <[email protected]>
bffd39d to
c4eb429
Compare
|
Thanks @JuliaKirschenheuter and @ChristophWurst 🙏 |
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Fixes #1681
Regarding #1351 seems to be fine