Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jun 6, 2023

Fixes #1681

Regarding #1351 seems to be fine

Before After
Screenshot from 2023-06-06 15-35-20 Screenshot from 2023-06-06 15-15-35

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @skjnldsv opinion before merging

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming the controls are still ok on very small screens like #1351

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not really fixed, please try with a window width of 320px (mobile).
Maybe we should just hide the volume bar, since mobile have their own volume keys ?

@JuliaKirschenheuter
Copy link
Contributor Author

Maybe we should just hide the volume bar, since mobile have their own volume keys ?

good idea! done

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/1681-Video_player_is_unusable_on_ios_(firefox_and_safari)_since_update_to_25 branch 3 times, most recently from 16ff689 to 4a9c388 Compare June 7, 2023 12:38
@ChristophWurst

This comment was marked as resolved.

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/1681-Video_player_is_unusable_on_ios_(firefox_and_safari)_since_update_to_25 branch from 4a9c388 to 3dccd84 Compare June 7, 2023 13:08
@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jun 7, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable26

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the fix/1681-Video_player_is_unusable_on_ios_(firefox_and_safari)_since_update_to_25 branch from 3dccd84 to 48054b4 Compare June 8, 2023 06:33
@skjnldsv
Copy link
Member

skjnldsv commented Jun 8, 2023

Seems like an outdated lockfile, no clue why

@skjnldsv skjnldsv force-pushed the fix/1681-Video_player_is_unusable_on_ios_(firefox_and_safari)_since_update_to_25 branch from 48054b4 to bffd39d Compare June 8, 2023 06:33
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 8, 2023
Signed-off-by: julia.kirschenheuter <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/1681-Video_player_is_unusable_on_ios_(firefox_and_safari)_since_update_to_25 branch from bffd39d to c4eb429 Compare June 8, 2023 06:56
@skjnldsv skjnldsv merged commit 4f4f511 into master Jun 8, 2023
@skjnldsv skjnldsv deleted the fix/1681-Video_player_is_unusable_on_ios_(firefox_and_safari)_since_update_to_25 branch June 8, 2023 09:25
@skjnldsv
Copy link
Member

skjnldsv commented Jun 8, 2023

Thanks @JuliaKirschenheuter and @ChristophWurst 🙏

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request Pending backport by the backport-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Video player is unusable on ios (firefox and safari) since update to 25

5 participants