Skip to content

[stable25] Fix: video player unusable on ios #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
Jul 12, 2023
Merged

[stable25] Fix: video player unusable on ios #1804

AndyScherzinger merged 1 commit into from
Jul 12, 2023

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jul 12, 2023

Backport of #1763

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jul 12, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jul 12, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Jul 12, 2023

/compile amend /

@hamza221 @nextcloud-command
Fix: video player unusable on ios
4625331 
Signed-off-by: hamza221 <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>

(cherry picked from commit 4ca1859)
Signed-off-by: julia.kirschenheuter <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the fix/video-fullscreen-iPhone-stable25 branch from 828d3cb to 4625331 Compare July 12, 2023 12:36
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Jul 12, 2023

agree with #1763 (comment)

@AndyScherzinger AndyScherzinger merged commit 754b4fb into stable25 Jul 12, 2023
@AndyScherzinger AndyScherzinger deleted the fix/video-fullscreen-iPhone-stable25 branch July 12, 2023 14:52
@AndyScherzinger AndyScherzinger added this to the Nextcloud 25.0.9 milestone Jul 12, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Jul 12, 2023

│ ✖ visual-regression.cy.js 00:24 15 14 1 - - │

Visual regression was not a false negative and needs a fix @JuliaKirschenheuter

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jul 12, 2023

Looping in @hamza221 @st3iny also

@blizzz blizzz mentioned this pull request Jul 12, 2023
Merged
@danxuliu
Copy link
Member

danxuliu commented Jul 26, 2023

│ ✖️ visual-regression.cy.js 00:24 15 14 1 - - │

Visual regression was not a false negative and needs a fix @JuliaKirschenheuter

If I am not mistaken this is fixed in #1830

@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@artonge artonge artonge approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review Waiting for reviews feedback-requested

Projects

None yet

Milestone

Nextcloud 25.0.9

Development

Successfully merging this pull request may close these issues.

7 participants

@JuliaKirschenheuter @skjnldsv @AndyScherzinger @danxuliu @artonge @hamza221