Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix fullscreen and button style
":deep()" was introduced in Vue 3, although it can be used in Vue 2 too
if vue-loader >= 5.10.0. However, in stable25 the viewer is using Vue 2
with vue-loader 5.9.8, so ":deep()" has no effect and therefore the
styles for fullscreen mode and buttons were not applied.

Given that the change from "::v-deep" to ":deep()" was done in a recent
backport and that, except for security fixes, the dependencies are not
bumped in stable versions "::v-deep" is used again instead of bumping
the vue-loader version.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
danxuliu authored and nextcloud-command committed Jul 26, 2023
commit 1c41bbe5ed53c11440c641cec95d86463a7f3ff8
4 changes: 2 additions & 2 deletions js/viewer-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/viewer-main.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/components/Videos.vue
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ video {
justify-self: center;
}

:deep() {
::v-deep {
.plyr:-webkit-full-screen video {
width: 100% !important;
height: 100% !important;
Expand Down