Skip to content

[stable28] fix: make prev and next slides not focusable and aria-hidden #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShGKme merged 3 commits into from
Jan 5, 2024
Merged

[stable28] fix: make prev and next slides not focusable and aria-hidden #2117

ShGKme merged 3 commits into from
Jan 5, 2024

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 5, 2024 •
edited by ShGKme
Loading

ShGKme added 2 commits January 5, 2024 11:03
@ShGKme @backportbot-nextcloud
fix: make prev and next slides not focusable and aria-hidden
1f5fa90 
But it doesn't work on a video slide, as it re-mounts the container and loses attributes.

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme @backportbot-nextcloud
test(a11y): visibility and focus on prev next slides
bb18caf 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added accessibility bug Something isn't working labels Jan 5, 2024
@skjnldsv skjnldsv changed the base branch from backport-2091-stable28 to stable28 January 5, 2024 11:06
@skjnldsv
Copy link
Member

skjnldsv commented Jan 5, 2024

Ah! it worked 😁

@skjnldsv skjnldsv changed the title [backport-2091-stable28] fix: make prev and next slides not focusable and aria-hidden [stable28] fix: make prev and next slides not focusable and aria-hidden Jan 5, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Jan 5, 2024

/compile

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jan 5, 2024
@ShGKme ShGKme linked an issue Jan 5, 2024 that may be closed by this pull request
[BITV] 9.1.3.2/4.1 - When the image viewer is open, in some cases, not only the alternative text of the visible image is read aloud but also that of a previous one. (1) nextcloud/server#41840
Closed
@ShGKme
Copy link
Contributor

ShGKme commented Jan 5, 2024

/compile

@nextcloud-command
chore(assets): Recompile assets
d24a127 
Signed-off-by: nextcloud-command <[email protected]>
@ShGKme ShGKme merged commit 960baa1 into stable28 Jan 5, 2024
@ShGKme ShGKme deleted the backport/2091/backport-2091-stable28 branch January 5, 2024 17:02
@ShGKme ShGKme added this to the Nextcloud 28.0.2 milestone Jan 5, 2024
@ShGKme ShGKme added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 5, 2024
@blizzz blizzz mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility bug Something isn't working

Projects

None yet

Milestone

Nextcloud 28.0.2

4 participants

@skjnldsv @ShGKme @nextcloud-command