Skip to content

[stable28] Improve handling of Node API properties #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 1 commit into from
Jan 18, 2024
Merged

[stable28] Improve handling of Node API properties #2128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Improve handling of Node API properties 
Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge
artonge committed Jan 18, 2024
commit 76648e6c481c846ab2cd776b6c6bb748274ff961
4 changes: 2 additions & 2 deletions js/viewer-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/viewer-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 9 additions & 2 deletions src/views/Viewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,12 +1110,19 @@ export default {
},

// Update etag of updated file to break cache.
/**
*
* @param {Node} node
*/
async handleFileUpdated(node) {
const index = this.fileList.findIndex(({ fileid: currentFileId }) => currentFileId === node.fileid)

this.fileList.splice(index, 1, { ...node, etag: node.etag })
// Ensure compatibility with the legacy data model that the Viewer is using. (see "model.ts").
// This can be removed once Viewer is migrated to the new Node API.
node.etag = node.attributes.etag
this.fileList.splice(index, 1, node)
if (node.fileid === this.currentFile.fileid) {
this.currentFile.etag = node.etag
this.currentFile.etag = node.attributes.etag
}
},

Expand Down