Skip to content

Bump NcVue to 8.4.0 #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JuliaKirschenheuter wants to merge 2 commits into from
Closed

Bump NcVue to 8.4.0 #2158

JuliaKirschenheuter wants to merge 2 commits into from

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Feb 8, 2024

Bump NcVue to v8.6.2

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Feb 8, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Feb 8, 2024
@emoral435
Copy link
Contributor

emoral435 commented Feb 8, 2024

Just as an FYI - this is why the first test is failing :) nextcloud/server#43444 Nifty, right?

@JuliaKirschenheuter
fix(files): update NcVue to 8.6.2
96b2c5a 
Signed-off-by: julia.kirschenheuter <[email protected]>
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Feb 8, 2024

/compile /

@nextcloud-command
chore(assets): Recompile assets
9e38c46 
Signed-off-by: nextcloud-command <[email protected]>
@Pytal
Copy link
Member

Pytal commented Feb 8, 2024

Already opened in #2157 ?

@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Feb 9, 2024

closing as duplicate of #2157

@github-actions
Copy link

github-actions bot commented Feb 23, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@skjnldsv skjnldsv deleted the bump/bump-ncvue-to-v8.6.2 branch September 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux Awaiting requested review from susnux

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

1 more reviewer

@emoral435 emoral435 emoral435 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review Waiting for reviews feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JuliaKirschenheuter @emoral435 @Pytal @nextcloud-command