fix(requesttoken): Make sure to use the correct requesttoken in WebdavClient #2339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vClient Signed-off-by: Marcel Müller <[email protected]>
Antreesy
approved these changes
Jun 17, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Looks legit, let's wait for a second opinion
skjnldsv
approved these changes
Jun 19, 2024
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/2339/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e870f7e2
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2339/stable28Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
2 tasks
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nextcloud/spreed#12529
Introduced in #2178 / #2179
Before the PR the
getRequestTokenwas called whencreateClientwas called, so it always contained the current value. After the PRgetRequestTokenis only called once when theheadersobject is created, so it will never change, which leads to being unable to open some pictures (see talk issue above).