Skip to content

Conversation

@sptcguy
Copy link

@sptcguy sptcguy commented Jul 8, 2024

Remove video{ max-height } attribute.

This fixes #1831

Remove video{ max-height } attribute.

Signed-off-by: sptcguy <[email protected]>
@artonge
Copy link
Contributor

artonge commented Jul 8, 2024

@hamza221 seems like you changed that line to fix full screen on iOS: #1819
Could you two ensure there is no regression from this change?

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv
Copy link
Member

@hamza221 seems like you changed that line to fix full screen on iOS: #1819 Could you two ensure there is no regression from this change?

@hamza221 any news?

@skjnldsv skjnldsv added bug Something isn't working regression Regression of a previous working feature 3. to review Waiting for reviews labels Sep 13, 2024
@tzerber
Copy link

tzerber commented Mar 25, 2025

Hi, is there any update on this ?

@susnux
Copy link
Contributor

susnux commented Sep 1, 2025

Thank you for the pull request, we fixed it with this now:

#2954

@susnux susnux closed this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feedback-requested regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertical video aspect ratio wrong in public view

5 participants